Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord Webhook pattern #648

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Discord Webhook pattern #648

merged 8 commits into from
Jan 6, 2025

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 27, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add Webhook for Discord
  • Fix Webhook of Slack to keep in value the cred instead full line

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review December 27, 2024 12:40
@babenek babenek requested a review from a team as a code owner December 27, 2024 12:41
kmnls
kmnls approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@kmnls
Copy link
Contributor

kmnls commented Jan 6, 2025 

Webhook Security

Please note that webhooks have been a common vulnerability for Discord servers. Be very careful about who has webhook permissions on your Discord server and guard the webhook URL closely. If a hacker gets your webhook URL, they will be able to post messages in your server while impersonating your team.

@babenek babenek merged commit 4a2e958 into Samsung:main Jan 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmnls kmnls kmnls approved these changes

@xDizzix xDizzix xDizzix approved these changes

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @kmnls @xDizzix